[NFC] Fix tests that were polluting the test directory #6498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few tests were creating files with the `%s` prefix, which expands to the test filename itself, so the test files were being created in the test directory and were never cleaned up. Another test was creating files called `%a.wast` and `%b.wast`, but `%a` and `%b` do not expand to anything, so this also polluted the test directory and caused problems with running other tests and fuzzing. Use the proper `%t` prefix to create all these files in a temporary location instead. Fixes #6429.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tests were creating files with the
%sprefix, which expands to the testfilename itself, so the test files were being created in the test directory and
were never cleaned up. Another test was creating files called
%a.wastand%b.wast, but%aand%bdo not expand to anything, so this also pollutedthe test directory and caused problems with running other tests and fuzzing.
Use the proper
%tprefix to create all these files in a temporary locationinstead.
Fixes #6429.