Skip to content

Conversation

@kripken
Copy link
Member

@kripken kripken commented Apr 1, 2024

That is, this should trap, but we did not:

(string.new_wtf16_array
  (array.new_default $array16
    (i32.const 1)
  )
  (i32.const 1)
  (i32.const 0) ;; end is less than the start
)

@kripken kripken requested a review from tlively April 1, 2024 19:43
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, probably worth auditing against the reference implementations given in https://github.com/WebAssembly/js-string-builtins/blob/main/proposals/js-string-builtins/Overview.md to see if we can find any other discrepancies.

@kripken kripken merged commit f984324 into WebAssembly:main Apr 1, 2024
@kripken kripken deleted the string.new.oob branch April 1, 2024 21:15
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants