Skip to content

GUFA: Fix hashing of GlobalInfo's type #6455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 3 commits into from
Mar 29, 2024
Merged

GUFA: Fix hashing of GlobalInfo's type #6455

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
def9d68
one
kripken Mar 29, 2024
03403b7
Revert "one"
kripken Mar 29, 2024
1b69449
fix
kripken Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/ir/possible-contents.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ class PossibleContents {
// The contents flowing out will be a Global, but of a non-nullable type,
// unlike the original global.
Type type;
// TODO: Consider adding a depth here, or merging this with ConeType in some
// way. In principle, not having depth info can lead to loss of
// precision.
bool operator==(const GlobalInfo& other) const {
return name == other.name && type == other.type;
}
Expand Down Expand Up @@ -305,8 +308,9 @@ class PossibleContents {
// Nothing to add.
} else if (isLiteral()) {
rehash(ret, getLiteral());
} else if (isGlobal()) {
rehash(ret, getGlobal());
} else if (auto* global = std::get_if<GlobalInfo>(&value)) {
rehash(ret, global->name);
rehash(ret, global->type);
} else if (auto* coneType = std::get_if<ConeType>(&value)) {
rehash(ret, coneType->type);
rehash(ret, coneType->depth);
Expand Down