Skip to content

Report timeout in interpretation of AtomicWait #6452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlively merged 1 commit into from
Mar 29, 2024
Merged

Report timeout in interpretation of AtomicWait #6452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wasm-interpreter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3431,7 +3431,7 @@ class ModuleRunnerBase : public ExpressionRunner<SubType> {
if (timeout.getSingleValue().getInteger() != 0) {
hostLimit("threads support");
}
return Literal(int32_t(0)); // equal
return Literal(int32_t(2)); // Timed out
Copy link
Member

@kripken kripken Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow - if there is no timeout, how can we timeout?

Copy link
Member Author

@tlively tlively Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timeout is zero nanoseconds.

Copy link
Member

@kripken kripken Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, reading the spec more carefully indeed 0 is just a brief timeout in effect...

}
Flow visitAtomicNotify(AtomicNotify* curr) {
NOTE_ENTER("AtomicNotify");
Expand Down
2 changes: 1 addition & 1 deletion test/lit/exec/atomic.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
(memory $0 23 256 shared)

;; CHECK: [fuzz-exec] calling wait_and_log
;; CHECK-NEXT: [LoggingExternalInterface logging 0]
;; CHECK-NEXT: [LoggingExternalInterface logging 2]
(func $wait_and_log (export "wait_and_log")
(call $log
(memory.atomic.wait64
Expand Down