Fix parsing of table imports #6446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types was ignored and `funcref` was always used instead.
tlively
approved these changes
Mar 27, 2024
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
FWIW, we will soon be switching to the next wat parser --new-wat-parser, which should already implement this correctly.
Contributor
Author
|
I have added a test in #6437 which would fail without this change... |
kripken
reviewed
Mar 27, 2024
src/wasm/wasm-s-parser.cpp
Outdated
|
|
||
| wasm.addTable(std::move(table)); | ||
|
|
||
| j++; // funcref |
Member
There was a problem hiding this comment.
Should this line not be removed? We increment j on line 3740 now.
kripken
approved these changes
Mar 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types was ignored and
funcrefwas always used instead.