Remove "minimal" JS import/export legalization #6428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Mar 22, 2024
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm if Emscripten tests pass
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 22, 2024
This change removes the "minimal" mode from `LegalizeJSInterface` which was added in #1883. The idea behind this change was to avoid legalizing most function except those we know that JS will be calling. The idea was that for dynamic linking we always want the non-legalized version to be shared between wasm module. These days we solve this problem in a different way with the `legalize-js-interface-export-originals` which exports the original functions alongside the legalized ones. Emscripten then always prefers the `$orig` functions when doing dynamic linking.
Member
Author
Everything except the one testing for this specific behaviour: emscripten-core/emscripten#21599 |
sbc100
force-pushed
the
minimal_legalize
branch
from
8875781 to
1a27447
Compare
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Mar 23, 2024
Member
|
@sbc100 This PR is cited as the reason for an Emscripten test being disabled: Do we still need to disable it / need that test? |
Member
Author
|
Yes, it looks like we can re-enable that test, but also it looks like we need to first ensure we have names for these stub functions: #6806 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the "minimal" mode from
LegalizeJSInterfacewhich was added in #1883.The idea behind this change was to avoid legalizing most function except those we know that JS will be calling. The idea was that for dynamic linking we always want the non-legalized version to be shared between wasm module. These days we solve this problem in a different way with the
legalize-js-interface-export-originalswhich exports the original functions alongside the legalized ones. Emscripten then always prefers the$origfunctions when doing dynamic linking.