[Strings] Fix precomputing of StringEq #6401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm confused; it looks like this PR changes all the string ops except StringEq? How could this have fixed behavior for StringEq? |
Member
Author
|
It moves them into the right place. By removing the bad |
kripken
commented
Mar 14, 2024
| } | ||
| Flow visitStringEncode(StringEncode* curr) { return Flow(NONCONSTANT_FLOW); } | ||
| Flow visitStringConcat(StringConcat* curr) { return Flow(NONCONSTANT_FLOW); } | ||
| Flow visitStringEq(StringEq* curr) { return Flow(NONCONSTANT_FLOW); } |
Member
Author
There was a problem hiding this comment.
This is the critical line for string.eq - this line overrode the parent, so we always returned "give up"...
tlively
approved these changes
Mar 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We incorrectly overrode the string operations in the interpreter's subclasses. But
string operations can be implemented in the topmost class there (as they depend on
no module state), so just implement them there, once, in a proper way.