-
Notifications
You must be signed in to change notification settings - Fork 831
Investigate ASan/TSan errors #6396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This does not seem tied to clang version: clang 14 and 15 error in the same manner. clang 16 does not install properly from the script, somehow the sanitizer library is not linkable, so I have not tested that one yet. |
This reverts commit bfe0345.
|
Clang 17 fixes asan! But not tsan... |
|
It looks like clang 18 fixes tsan as well (which I see makes sense based on this timeline). So, the best guess here is that something changed in the VMs and clang needs a very recent fix, from just a few months ago, to keep working. Bizarrely, I scanned many repos on github using sanitizers and none seem to hit this problem. I tried installing clang the way they did, I tried copying their flags, but nothing worked. Only using latest clang helps, but for all those other repos (top 10 results for github actions with asan) somehow things work without it... |
sbc100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we still have plenty of coverage of building with older versions of clang in the other builders?
|
Yeah, we still use the default clang elsewhere which is 14. We also have gcc testing. |
Since yesterday those jobs have been erroring out very early in an unclear way. asan just halts, and tsan says
My best guess is that something changed in the VM this runs on.