Skip to content

Conversation

@kripken
Copy link
Member

@kripken kripken commented Mar 13, 2024

Since yesterday those jobs have been erroring out very early in an unclear way. asan just halts, and tsan says

FATAL: ThreadSanitizer: unexpected memory mapping 0x63c6eeb8b000-0x63c6eebae000

My best guess is that something changed in the VM this runs on.

@kripken kripken changed the title Look into ASan/TSan again Investigate ASan/TSan errors Mar 14, 2024
@kripken
Copy link
Member Author

kripken commented Mar 14, 2024

This does not seem tied to clang version: clang 14 and 15 error in the same manner. clang 16 does not install properly from the script, somehow the sanitizer library is not linkable, so I have not tested that one yet.

@kripken
Copy link
Member Author

kripken commented Mar 14, 2024

Clang 17 fixes asan! But not tsan...

@kripken
Copy link
Member Author

kripken commented Mar 14, 2024

It looks like clang 18 fixes tsan as well (which I see makes sense based on this timeline). So, the best guess here is that something changed in the VMs and clang needs a very recent fix, from just a few months ago, to keep working.

Bizarrely, I scanned many repos on github using sanitizers and none seem to hit this problem. I tried installing clang the way they did, I tried copying their flags, but nothing worked. Only using latest clang helps, but for all those other repos (top 10 results for github actions with asan) somehow things work without it...

@kripken kripken requested review from aheejin, sbc100 and tlively March 14, 2024 20:26
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we still have plenty of coverage of building with older versions of clang in the other builders?

@kripken
Copy link
Member Author

kripken commented Mar 14, 2024

Yeah, we still use the default clang elsewhere which is 14. We also have gcc testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants