Skip to content

OptimizeAddedConstants: Replace an assert with a proper error #6375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 1 commit into from
Mar 4, 2024
Merged

OptimizeAddedConstants: Replace an assert with a proper error #6375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/passes/OptimizeAddedConstants.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,11 @@ struct OptimizeAddedConstants
}

void doWalkFunction(Function* func) {
// This pass is only valid under the assumption of unused low memory.
assert(getPassOptions().lowMemoryUnused);
if (!getPassOptions().lowMemoryUnused) {
Fatal() << "OptimizeAddedConstants can only be run when the "
<< "--low-memory-unused flag is set.";
}

// Multiple passes may be needed if we have x + 4 + 8 etc. (nested structs
// in C can cause this, but it's rare). Note that we only need that for the
// propagation case (as 4 + 8 would be optimized directly if it were
Expand Down