Skip to content

Fuzzer: Mark Roundtrip pass as adding effects #6366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 1 commit into from
Feb 29, 2024
Merged

Fuzzer: Mark Roundtrip pass as adding effects #6366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/passes/RoundTrip.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@
namespace wasm {

struct RoundTrip : public Pass {
// Reloading the wasm may alter function names etc., which means our global
// function effect tracking can get confused, and effects may seem to appear.
// To avoid that, mark this pass as adding effects, which will clear all
// cached effects and such.
bool addsEffects() override { return true; }

void run(Module* module) override {
BufferWithRandomAccess buffer;
// Save features, which would not otherwise make it through a round trip if
Expand Down