[NFC] Add some comments about flow in SubtypingDiscoverer and Unsubtyping #6359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Feb 28, 2024
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Just to make sure I understand: the reason we don't just go ahead and use noteNonFlowSubtype in all these places in subtype-exprs.h is because then we would have to do more work in Unsubtyping to make sure it continues doing the right thing?
Member
Author
|
Yes. I do think it might actually just work atm, but it would only add complexity and risk I think. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I audited all of SubtypingDiscoverer for flow/non-flow constraints and added
some comments to clarify things for our future selves if we ever need to
generalize it.