Validator: Check subtyping in CallIndirect [DO NOT LAND] #6336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 requires this, e.g.
errors on
However, @tlively you wrote otherwise in a test, so I am confused:
binaryen/test/lit/passes/unsubtyping.wast
Lines 525 to 536 in f6bb943
Reading the main spec, it still mentions only funcref, so it is pre-typed-function-references I guess. Reading the typed function references spec I only see it change the requirement from
funcreftoref null func. I also cannot find anything in the overviews, so I am lost as to what the correct behavior is.cc @jakobkummerow for the V8 behavior - am I reading that error right, and if so where in the spec is that validation rule added?