Skip to content

GUFA: Propagate string literals #6262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 5 commits into from
Feb 1, 2024
Merged

GUFA: Propagate string literals #6262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd1f2e0
GUFA: Propagate string literals
kripken Jan 31, 2024
ec36165
format
kripken Jan 31, 2024
9cdcb1a
test
kripken Jan 31, 2024
562d78f
test
kripken Jan 31, 2024
e382bf1
Merge remote-tracking branch 'origin/main' into gufa.strings
kripken Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/ir/possible-contents.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,8 @@ struct InfoCollector
addRoot(curr, PossibleContents::exactType(curr->type));
}
void visitStringConst(StringConst* curr) {
addRoot(curr, PossibleContents::exactType(curr->type));
addRoot(curr,
PossibleContents::literal(Literal(std::string(curr->string.str))));
}
void visitStringMeasure(StringMeasure* curr) {
// TODO: optimize when possible
Expand Down
59 changes: 59 additions & 0 deletions test/lit/passes/gufa-strings.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
;; NOTE: Assertions have been generated by update_lit_checks.py --all-items and should not be edited.
;; RUN: foreach %s %t wasm-opt -all --gufa -S -o - | filecheck %s

(module
;; CHECK: (type $0 (func))

;; CHECK: (global $foo (mut (ref string)) (string.const "foo"))
(global $foo (mut (ref string)) (string.const "foo"))

;; CHECK: (global $bar (mut (ref string)) (string.const "bar"))
(global $bar (mut (ref string)) (string.const "bar"))

;; CHECK: (global $baz (mut (ref string)) (string.const "baz"))
(global $baz (mut (ref string)) (string.const "baz"))

;; CHECK: (func $set (type $0)
;; CHECK-NEXT: (global.set $foo
;; CHECK-NEXT: (string.const "foo")
;; CHECK-NEXT: )
;; CHECK-NEXT: (global.set $bar
;; CHECK-NEXT: (string.const "BAR_BAR_BAR")
;; CHECK-NEXT: )
;; CHECK-NEXT: )
(func $set
;; Modify $foo to the same value as it begins.
(global.set $foo
(string.const "foo")
)
;; Modify $bar to a new value
(global.set $bar
(string.const "BAR_BAR_BAR")
)
;; Do not modify $baz at all.
)

;; CHECK: (func $get (type $0)
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (string.const "foo")
;; CHECK-NEXT: )
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (global.get $bar)
;; CHECK-NEXT: )
;; CHECK-NEXT: (drop
;; CHECK-NEXT: (string.const "baz")
;; CHECK-NEXT: )
;; CHECK-NEXT: )
(func $get
;; $foo and $baz can be optimized, but not $bar.
(drop
(global.get $foo)
)
(drop
(global.get $bar)
)
(drop
(global.get $baz)
)
)
)