Skip to content

Conversation

@ericvergnaud
Copy link
Contributor

No description provided.

@ericvergnaud
Copy link
Contributor Author

Fixes #5270

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we test this in test/example/c-api-kitchen-sink.c (I grepped for BinaryenArrayNewFixed under test/), please add a case with this there.

@ericvergnaud
Copy link
Contributor Author

Done, but the workflow is blocked, so not sure if the test succeeds

@kripken
Copy link
Member

kripken commented Jan 25, 2024

I ran the workflow here. But it will be faster to debug locally, which you can do with ./check.py example.

@ericvergnaud
Copy link
Contributor Author

@kripken done, hopefully my last push will fix all failures

@ericvergnaud
Copy link
Contributor Author

ericvergnaud commented Jan 25, 2024

btw what is the option for building the binaryen wasm module with dwarf attached such that I can understand the failing assertions (when using validate on a "manually" built module) ? The readme says it's supported, but not how...

@kripken
Copy link
Member

kripken commented Jan 25, 2024

I think making a debug build should be enough. So something like emcmake cmake -DCMAKE_BUILD_TYPE=Debug [..]

@kripken kripken merged commit 0375d95 into WebAssembly:main Jan 25, 2024
@ericvergnaud
Copy link
Contributor Author

A debug build definitely provides a lot more info. Looks like dwarf is embedded, but unfortunately it's not used by my debugger (it works with map files)...

@ericvergnaud ericvergnaud deleted the implement-array-new-data branch January 30, 2024 09:50
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants