wasm-reduce: Improve tryToReduceCurrentToConst() #6193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheejin
approved these changes
Dec 21, 2023
src/tools/wasm-reduce.cpp
Outdated
| // It's a number: try to replace it with a 0 or a 1 (trying more values | ||
| // could make sense too, but these handle most cases). | ||
| auto* c = builder->makeConst(Literal::makeZero(curr->type)); | ||
| if (ExpressionAnalyzer::equal(c, curr)) { |
Member
There was a problem hiding this comment.
Can we use Literal::isZero or something for checking before making? (It doesn't seem to have Literal::isOne though.. Can we add it?)
Member
Author
There was a problem hiding this comment.
Good idea, yeah, we can be a little more efficient here. I did that now.
Separately, not sure if it's worth adding Literal::isOne. It would save a little code but it is rare to check that I suspect...
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Avoid replacing with the exact same thing in the case of RefNull and a default tuple. Also be more careful with handling of numbers. Before we exited immediately if we saw a number, but we can try to replace a number with a 0 or a 1, even if it was a number before. That is, we consider 1 simpler than e.g. 12345678, and 0 simpler than 1.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid replacing with the exact same thing in the case of RefNull and a default
tuple.
Also be more careful with handling of numbers. Before we exited immediately
if we saw a number, but we can try to replace a number with a 0 or a 1, even
if it was a number before. That is, we consider 1 simpler than 12345678, and
0 simpler than 1.