Skip to content

Conversation

@tlively
Copy link
Member

@tlively tlively commented Dec 7, 2023

Like delegate, rethrow takes a Try label. Refactor the delegate handling so
that Try can share its logic.

@tlively
Copy link
Member Author

tlively commented Dec 7, 2023

Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that this can be simpler after you did all the hard work in #6128! Can we add a test where rethrow is in the try part of the innermost try (and catch part of an outer try) as well?

Base automatically changed from parser-table-ops to main December 12, 2023 23:40
Like `delegate`, rethrow takes a `Try` label. Refactor the delegate handling so
that `Try` can share its logic.
@tlively tlively merged commit 8e91992 into main Dec 13, 2023
@tlively tlively deleted the parser-rethrow branch December 13, 2023 02:50
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
Like `delegate`, rethrow takes a `Try` label. Refactor the delegate handling so
that `Try` can share its logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants