Add an Asyncify option to propagate the addList #5935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5935 +/- ##
==========================================
+ Coverage 42.60% 43.05% +0.44%
==========================================
Files 484 492 +8
Lines 74837 74968 +131
Branches 11922 11683 -239
==========================================
+ Hits 31887 32279 +392
+ Misses 39750 39457 -293
- Partials 3200 3232 +32
|
kripken
reviewed
Sep 25, 2023
kripken
reviewed
Sep 25, 2023
test/lit/passes/asyncify_pass-arg=asyncify-addlist@[email protected]
Outdated
Show resolved
Hide resolved
kripken
approved these changes
Apr 1, 2024
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Sorry for the delay here! I think I missed a notification here or something. This looks great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will take #3794 over.
New asyncify flag
--pass-arg=asyncify-propagate-addlistwill change--pass-arg=asyncify-addlistbehavior, callers of functions in a asyncify-addlist will be also instrumented.