Skip to content

Fuzzer: Run --dce when GC is enabled #5677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 3 commits into from
Apr 19, 2023
Merged

Fuzzer: Run --dce when GC is enabled #5677

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87f7d68
workaround
kripken Apr 18, 2023
2365612
bettr
kripken Apr 18, 2023
8214dc4
fix
kripken Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions scripts/fuzz_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,15 @@ def randomize_fuzz_settings():
FUZZ_OPTS += ['--legalize-js-interface']
else:
LEGALIZE = False

# if GC is enabled then run --dce at the very end, to ensure that our
# binaries validate in other VMs, due to how non-nullable local validation
# and unreachable code interact. see
# https://github.com/WebAssembly/binaryen/pull/5665
# https://github.com/WebAssembly/binaryen/issues/5599
if '--disable-gc' not in FEATURE_OPTS:
FUZZ_OPTS += ['--dce']

print('randomized settings (NaNs, OOB, legalize):', NANS, OOB, LEGALIZE)


Expand Down