[Wasm GC] DeadArgumentElimination: Do not refine return types of tail callees #4025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Jul 27, 2021
Member
|
I think this should be reverted after #4032. Sorry I didn't think about this sooner! Happy to chat more about this tomorrow, too. |
Member
Author
|
No worries, sounds good. After that lands I'll revert the code and update the tests here. And I'll convert the other PR to just a test. |
kripken
added a commit
that referenced
this pull request
Jul 28, 2021
Partially reverts #4025, removing the code and updates the test to show we do the optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a tail call, we can't change the return type of the function, as it
must match in the functions doing a tail call of it.