Skip to content

bugfix(api): Fix api reponse on build failure #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2024
Merged

bugfix(api): Fix api reponse on build failure #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dist/action.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11302,20 +11302,20 @@ async function run() {
markedAsInProgress = true;
}
}
if (latestStage.status === "failed") {
if (latestStage.status === "failure") {
waiting = false;
core.setFailed(`Deployment failed on step: ${latestStage.name}!`);
await updateDeployment(token, deployment, "failure");
return;
}
if (latestStage.name === "deploy" && ["success", "failed"].includes(latestStage.status)) {
if (latestStage.name === "deploy" && ["success", "failure"].includes(latestStage.status)) {
waiting = false;
const aliasUrl = deployment.aliases && deployment.aliases.length > 0 ? deployment.aliases[0] : deployment.url;
core.setOutput("id", deployment.id);
core.setOutput("environment", deployment.environment);
core.setOutput("url", deployment.url);
core.setOutput("alias", aliasUrl);
core.setOutput("success", deployment.latest_stage.status === "success" ? true : false);
core.setOutput("success", deployment.latest_stage.status === "success");
if (token !== "") {
await updateDeployment(token, deployment, latestStage.status === "success" ? "success" : "failure");
}
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,14 @@ export default async function run() {
}
}

if (latestStage.status === 'failed') {
if (latestStage.status === 'failure') {
waiting = false;
core.setFailed(`Deployment failed on step: ${latestStage.name}!`);
await updateDeployment(token, deployment, 'failure');
return;
}

if (latestStage.name === 'deploy' && ['success', 'failed'].includes(latestStage.status)) {
if (latestStage.name === 'deploy' && ['success', 'failure'].includes(latestStage.status)) {
waiting = false;

const aliasUrl = deployment.aliases && deployment.aliases.length > 0 ? deployment.aliases[0] : deployment.url;
Expand All @@ -69,7 +69,7 @@ export default async function run() {
core.setOutput('environment', deployment.environment);
core.setOutput('url', deployment.url);
core.setOutput('alias', aliasUrl);
core.setOutput('success', deployment.latest_stage.status === 'success' ? true : false);
core.setOutput('success', deployment.latest_stage.status === 'success');

// Update deployment (if enabled)
if (token !== '') {
Expand Down
2 changes: 1 addition & 1 deletion src/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export interface Stage {
name: 'queued'|'initialize'|'clone_repo'|'build'|'deploy';
started_on: string;
ended_on: string;
status: 'idle'|'active'|'success'|'failed'
status: 'idle'|'active'|'success'|'failure'
}

export interface Trigger {
Expand Down