Skip to content

Conversation

@eadz
Copy link

@eadz eadz commented Nov 28, 2024

Fix for existing mod.

The servo was turned off before it reached target angle, which caused crashes. Simple fix.

  • [ x] I have read the rules available here and
    my mod adheres to these rules.
  • [x ] This mod was created by myself and I agree to publish it under the repository
    license

The servo was turned off before it reached target angle.
@mjonuschat
Copy link
Collaborator

@chirpy2605 Any thoughts on this change? Given that it's your mod, does it look good to you?

@chirpy2605
Copy link
Collaborator

Yeah, go for it. I've not had other reports of problems, but if it helps I see no problems adding it

@github-actions
Copy link

Hi, thank you for submitting your PR.
Please find below the results of the automated PR checker:

Added/Changed mods detected in this PR:

Item Result Description/Error Printer compatibility/Error Detail
chirpy/NozzleWiper ✅ SUCCESS Servo powered nozzle wiper and purge bucket V0.2

Tool check results overview:

Tool ⚠️ 💀
File checker 26 1
Markdown link checker 17
Readme generator 1
Mod structure checker
STL rotation checker 7 1
STL corruption checker 8

Tool check results details:

SUCCESS: ✅

File checker

Item Result Reason
chirpy/NozzleWiper/nozzlewiper.cfg ✅ SUCCESS
chirpy/NozzleWiper/.metadata.yml ✅ SUCCESS
chirpy/NozzleWiper/README.md ✅ SUCCESS
chirpy/NozzleWiper/STLs/Carrier_Joint.stl ✅ SUCCESS
chirpy/NozzleWiper/STLs/Purge_Bucket.stl ✅ SUCCESS
chirpy/NozzleWiper/STLs/Parallel_Arm.stl ✅ SUCCESS
chirpy/NozzleWiper/STLs/Brush_Carrier.stl ✅ SUCCESS
chirpy/NozzleWiper/STLs/Servo_Mount.stl ✅ SUCCESS
chirpy/NozzleWiper/STLs/Servo_Joint.stl ✅ SUCCESS
chirpy/NozzleWiper/STLs/Servo_Arm.stl ✅ SUCCESS
chirpy/NozzleWiper/STLs/Allinone.stl ✅ SUCCESS
chirpy/NozzleWiper/CAD/NozzleWiper.step ✅ SUCCESS
chirpy/NozzleWiper/images/armtobrushmount.jpg ✅ SUCCESS
chirpy/NozzleWiper/images/armtomount.jpg ✅ SUCCESS
chirpy/NozzleWiper/images/completed.jpg ✅ SUCCESS
chirpy/NozzleWiper/images/servosetting.jpg ✅ SUCCESS
chirpy/NozzleWiper/images/brush.jpg ✅ SUCCESS
chirpy/NozzleWiper/images/bucket.jpg ✅ SUCCESS
chirpy/NozzleWiper/images/wireplacement.jpg ✅ SUCCESS
chirpy/NozzleWiper/images/mounted.jpg ✅ SUCCESS
chirpy/NozzleWiper/images/NozzleWiper.gif ✅ SUCCESS
chirpy/NozzleWiper/images/fullyopen.jpg ✅ SUCCESS
chirpy/NozzleWiper/images/servomounting.jpg ✅ SUCCESS
chirpy/NozzleWiper/images/armassembly.jpg ✅ SUCCESS
chirpy/NozzleWiper/images/parts.jpg ✅ SUCCESS
chirpy/NozzleWiper/images/brushholder.jpg ✅ SUCCESS

Markdown link checker

Item Result Reason
chirpy/NozzleWiper/README.md ✅ SUCCESS Link 'https://github.com/chestwood96/SlideSwipe' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Link 'https://github.com/chestwood96' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/NozzleWiper.gif' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/parts.jpg' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/servosetting.jpg' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/bucket.jpg' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/brush.jpg' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/servomounting.jpg' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/armassembly.jpg' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/armtomount.jpg' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/armtobrushmount.jpg' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/completed.jpg' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/brushholder.jpg' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/fullyopen.jpg' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Link 'https://github.com/timmit99/Klipper-Expander' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/wireplacement.jpg' is valid!
chirpy/NozzleWiper/README.md ✅ SUCCESS Relative link 'images/mounted.jpg' is valid!

Readme generator

Item Result Description/Error Printer compatibility/Error Detail
chirpy/NozzleWiper ✅ SUCCESS Servo powered nozzle wiper and purge bucket V0.2

STL rotation checker

Item Result Original orientation Suggested orientation
Purge_Bucket.stl ✅ SUCCESS
Brush_Carrier.stl ✅ SUCCESS
Servo_Joint.stl ✅ SUCCESS
Carrier_Joint.stl ✅ SUCCESS
Servo_Mount.stl ✅ SUCCESS
Servo_Arm.stl ✅ SUCCESS
Allinone.stl ✅ SUCCESS

STL corruption checker

Item Result Number of STL fixes applicable
Carrier_Joint.stl ✅ SUCCESS 0
Purge_Bucket.stl ✅ SUCCESS 0
Parallel_Arm.stl ✅ SUCCESS 0
Brush_Carrier.stl ✅ SUCCESS 0
Servo_Mount.stl ✅ SUCCESS 0
Servo_Joint.stl ✅ SUCCESS 0
Servo_Arm.stl ✅ SUCCESS 0
Allinone.stl ✅ SUCCESS 0

WARNING: ⚠️

File checker

Item Result Reason
chirpy/NozzleWiper/images/NozzleWiper.gif ⚠️ WARNING This file is larger than 2 MB!

STL rotation checker

Item Result Original orientation Suggested orientation
Parallel_Arm.stl ⚠️ WARNING


I am a 🤖, this comment was generated automatically!

Made with ❤️ by the VoronDesign GitHub Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants