Skip to content

Conversation

bdash
Copy link
Contributor

@bdash bdash commented Jul 31, 2025

I'm not entirely clear why this function copies the callbacks to the heap given that BNPerformCustomRequest is synchronous. Rather than changing that, I added an explicit Box::from_raw to ensure it is deallocated. This matches what is done within perform_request.

@emesare
Copy link
Member

emesare commented Aug 3, 2025

I think we probably should just avoid boxing it altogether and pass it by ref into the function: 966097b

@bdash
Copy link
Contributor Author

bdash commented Aug 5, 2025

@emesare is going to fix the leak via 966097b in the near future.

@bdash bdash closed this Aug 5, 2025
@bdash bdash deleted the rust-downloadinstance-leak branch August 5, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants