feat: use vscode native nav back to avoid surpurise and inconsistency #9286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `<C-o>` now use workbench.action.navigateBack instead of hand rolled jump list, so that `gd` and mouse goto state are consistent. - `<C-t>` is unchanged and still use hand rolled jump list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice: This is more or less a BREAKING CHANGE!
What this PR does / why we need it:
<C-o>use hand rolled track list to go back, and it breaks after mouse navigation (eg.Cmd+Click). This surprises lots of people, like Bug Report – Issue with Go-to-Definition and Back feature causing incorrect cursor positioning microsoft/vscode#177598<C-o>to let it useworkbench.action.navigateBackChanges:
<C-o>now use workbench.action.navigateBack instead of hand rolled jump list, so thatgdand mouse goto state are consistent.<C-t>is unchanged and still use hand rolled jump list.Which issue(s) this PR fixes
Special notes for your reviewer:
This will be a breaking change but IMO it's worth it since
workbench.action.navigateBackis used much more often then Vim's jump list