-
Notifications
You must be signed in to change notification settings - Fork 690
SystemTheme TextColor correction #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SystemTheme TextColor correction #193
Conversation
Codecov Report
@@ Coverage Diff @@
## feature #193 +/- ##
==========================================
Coverage 92.38% 92.38%
Complexity 1036 1036
==========================================
Files 136 136
Lines 3152 3152
Branches 215 215
==========================================
Hits 2912 2912
Misses 160 160
Partials 80 80 |
Please note that Please take a look at Support Lib 23.2.0 blog post AppCompat DayNight theme section. |
Off cause P.S. I just started to recode the whole theme mechanism. I plan to just use |
If you wan't I can reimplement the |
To merge this pull request in the current state, please put light theme back in. Otherwise we will wait until you have implemented new theme mechanism. |
shure! thats why I firstly just uncommented it. (even when I can't see the reason why" |
What does this implement/fix? Please describe.
-I temporally removed the light theme
Does this close any currently open issues?