Skip to content

Conversation

Leptopoda
Copy link
Contributor

@Leptopoda Leptopoda commented Jun 17, 2018

What does this implement/fix? Please describe.

  • fixing the color issue when the system theme is in "light/day" mode
    -I temporally removed the light theme

Does this close any currently open issues?

  • not marked as one

@Leptopoda Leptopoda changed the title Feature SystemTheme TextColor correction Jun 17, 2018
@codecov
Copy link

codecov bot commented Jun 17, 2018

Codecov Report

Merging #193 into feature will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             feature     #193   +/-   ##
==========================================
  Coverage      92.38%   92.38%           
  Complexity      1036     1036           
==========================================
  Files            136      136           
  Lines           3152     3152           
  Branches         215      215           
==========================================
  Hits            2912     2912           
  Misses           160      160           
  Partials          80       80

@VREMSoftwareDevelopment
Copy link
Owner

Please note that Theme.AppCompat.Light is not Theme.AppCompat.DayNight.

Please take a look at Support Lib 23.2.0 blog post AppCompat DayNight theme section.

@Leptopoda
Copy link
Contributor Author

Off cause DayNight isn't the same as Light but the most ROM's (except lineage and some others) use the day theme as their default. So the app will display the Light/Day theme when the SystemTheme is chosen. Those ROM's giving the ability to change the mode to Night will display dark. (those roms provide the ability to make the theme light system wide). Of cause with the removal of the LightTheme you lose the ability to force the app to light when the OS is Dark. But who doesn't want system integration?

P.S. I just started to recode the whole theme mechanism. I plan to just use AppCompatDelegate to switch themes and thus only one theme is needed. I just don't have time jet.

@Leptopoda
Copy link
Contributor Author

If you wan't I can reimplement the LightTheme so you can force the theme to light and just have to merge the ThemeCorrection where the Action bar and its Text color where to similar.

@VREMSoftwareDevelopment
Copy link
Owner

VREMSoftwareDevelopment commented Jun 20, 2018

To merge this pull request in the current state, please put light theme back in. Otherwise we will wait until you have implemented new theme mechanism.

@Leptopoda
Copy link
Contributor Author

shure! thats why I firstly just uncommented it. (even when I can't see the reason why"

@VREMSoftwareDevelopment VREMSoftwareDevelopment merged commit 17fdb4a into VREMSoftwareDevelopment:feature Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants