project-s: シンガーを表示・設定するUIを追加 #999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
undefinedのチェックができていない箇所があるので修正します！ |
Hiroshiba
approved these changes
Oct 30, 2022
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM！！
なんか一気にそれっぽくなった（？）と思いました！！
Member
|
ありがとうございます、シンタックスハイライトがちゃんと動作するようになってとても見やすくなりました！！ |
romot-co
approved these changes
Nov 3, 2022
Collaborator
romot-co
left a comment
romot-co
left a comment
There was a problem hiding this comment.
@sigprogramming @Hiroshiba
LGTMです！！！
キャラ選べるようになって正直テンションあがりました！ありがとうございます！
(諸々片付いたため、今日からまた作業します…！)
Collaborator
Author
|
レビューありがとうございます！こちらマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
シンガーの表示と設定を行うUIを追加します。
AudioCellのCharacterMenuを利用するため、コンポーネントとして切り出しています。
シンガーの表示ですが、キャラクターによって頭身や縮尺が違うため、現状一部キャラクターで見切れます。
レビューよろしくお願いいたします。
関連 Issue
ref VOICEVOX/voicevox_project#15
ref #981
スクリーンショット・動画など