-
Notifications
You must be signed in to change notification settings - Fork 346
chore(build): .AppImage.7zの圧縮レベルを0にする #2774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ: |
|
@oech3
|
|
(同コミットで) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR optimizes the build process by setting the 7z compression level to 0 for AppImage files, since AppImage files are already compressed internally. This change aims to speed up the extraction process while maintaining compatibility with existing installation scripts.
- Updated 7z command to use
-mx=0(no compression) when creating split archives - Added explanatory comments about why compression level 0 is used
- Maintained the .7z format requirement for installer script compatibility
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Hiroshiba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
調査ありがとうございます!
まあダウンロードサイズが20MB増えちゃうのはデメリットな気がしないでもないですが、2回圧縮する方が変な気がするのでこの形が良いのかな~と思いました。
一応 cc まで!! @sevenc-nanashi @sabonerune @madosuki
sevenc-nanashi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
まぁ特に問題なさそう。
内容
AppImageは圧縮済みなので、7zの圧縮レベルを0にして展開を早くします。
7z無しで単に分割する(#2750)とスクリプトの互換性が壊れる為。
残念ながら、この方法ではインストール中にディスク上に大きなファイルが出現するのまでは防げません(
curlから7z -siにパイプできそうですが、できません)。