-
Notifications
You must be signed in to change notification settings - Fork 346
feat: ボリューム編集: ドメインロジックの追加 #2769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ボリューム編集: ドメインロジックの追加 #2769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds domain logic for volume editing functionality to match the existing pitch editing workflow. The main purpose is to integrate volume editing into the rendering pipeline and prepare for simultaneous display with the sequencer.
- Separated volume editor state from the sequencer state machine to enable independent operation
- Added volume editing application logic to the track rendering process
- Removed volume editing from the sequencer's edit targets
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/store/type.ts | Removed "VOLUME" from SequencerEditTarget and added volume editor state definitions |
| src/store/singing.ts | Added volume editor state and actions to the store |
| src/sing/songTrackRendering.ts | Integrated volume editing into the rendering pipeline |
| src/sing/domain.ts | Implemented applyVolumeEdit function for volume modification logic |
| src/composables/useSequencerStateMachine.ts | Removed volume editing handling from sequencer state machine |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ: |
sigprogramming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Sig <[email protected]>
…-co/voicevox into add/volue-edit_2733-domain
|
あといけそうなら @sevenc-nanashi さんのレビューもいただけると心強そうです! |
sevenc-nanashi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
問題なさそう。
|
マージします。 |
内容
ボリューム編集機能のドメインロジックを追加しています。
ピッチ編集と同様の流れにしています。
また、ボリューム編集の表示やツール選択させるための準備を行い、次の実装ステップへの橋渡しを行います。
関連 Issue
ref #2733
スクリーンショット・動画など
なし
その他
なし