Skip to content

Conversation

@romot-co
Copy link
Collaborator

@romot-co romot-co commented Oct 3, 2025

内容

ボリューム編集機能のドメインロジックを追加しています。
ピッチ編集と同様の流れにしています。

  • 合成前にトラックのボリューム編集を反映させる処理をレンダラーへ組み込む

また、ボリューム編集の表示やツール選択させるための準備を行い、次の実装ステップへの橋渡しを行います。

関連 Issue

ref #2733

スクリーンショット・動画など

なし

その他

なし

@romot-co romot-co requested a review from Copilot October 3, 2025 14:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds domain logic for volume editing functionality to match the existing pitch editing workflow. The main purpose is to integrate volume editing into the rendering pipeline and prepare for simultaneous display with the sequencer.

  • Separated volume editor state from the sequencer state machine to enable independent operation
  • Added volume editing application logic to the track rendering process
  • Removed volume editing from the sequencer's edit targets

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/store/type.ts Removed "VOLUME" from SequencerEditTarget and added volume editor state definitions
src/store/singing.ts Added volume editor state and actions to the store
src/sing/songTrackRendering.ts Integrated volume editing into the rendering pipeline
src/sing/domain.ts Implemented applyVolumeEdit function for volume modification logic
src/composables/useSequencerStateMachine.ts Removed volume editing handling from sequencer state machine

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Oct 3, 2025

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:781e878

Copy link
Collaborator

@sigprogramming sigprogramming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba
Copy link
Member

あといけそうなら @sevenc-nanashi さんのレビューもいただけると心強そうです!
(PRの切り分けをどうしていくのが良さそうか、という経験も溜まりそうなので 🙏 )

Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題なさそう。

@sevenc-nanashi
Copy link
Member

マージします。

@sevenc-nanashi sevenc-nanashi added this pull request to the merge queue Oct 13, 2025
Merged via the queue into VOICEVOX:main with commit 3b0e5ab Oct 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants