Skip to content

refactor: エンジン設定の初期化処理をprivateメソッドに分離 #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2025
+11 −5
Merged

refactor: エンジン設定の初期化処理をprivateメソッドに分離 #2766

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d200aed
refactor: エンジン設定の初期化処理をprivateメソッドに分離
Hiroshiba Oct 1, 2025
43b6ffd
Apply suggestion from @Hiroshiba
Hiroshiba Oct 18, 2025
ae54f58
Merge upstream/main into refactor/extract-initialize-engine-settings
Hiroshiba Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/backend/electron/engineAndVvppController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,11 +344,11 @@ export class EngineAndVvppController {
this.configManager.set(`engineSettings`, engineSettings);
}

// エンジンの準備と起動
async launchEngines() {
// AltPortInfosを再生成する。
this.engineInfoManager.initializeAltPortInfo();

/**
* 各エンジンの設定を初期化する。
* 設定が存在しないエンジンに対してデフォルト値を設定する。
*/
private initializeEngineSettings() {
// TODO: デフォルトエンジンの処理をConfigManagerに移してブラウザ版と共通化する
const engineInfos = this.engineInfoManager.fetchEngineInfos();
const engineSettings = this.configManager.get("engineSettings");
Expand All @@ -359,7 +359,16 @@ export class EngineAndVvppController {
}
}
this.configManager.set("engineSettings", engineSettings);
}

// エンジンの準備と起動
async launchEngines() {
// AltPortInfosを再生成する。
this.engineInfoManager.initializeAltPortInfo();

this.initializeEngineSettings();

const engineInfos = this.engineInfoManager.fetchEngineInfos();
await this.engineProcessManager.runEngineAll();
this.runtimeInfoManager.setEngineInfos(
engineInfos,
Expand Down
Loading