Skip to content

Conversation

@Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Oct 1, 2025

内容

メソッドにするほどのものではない不要っぽい処理をインライン化しました。

  • src/backend/electron/ipcMainHandle.ts:306 でエンジン設定更新処理を直接 configManager に適用するようインライン化。
  • src/backend/electron/engineAndVvppController.ts:340 から不要になった updateEngineSetting メソッドを削除。

関連 Issue

  • なし

スクリーンショット・動画など

  • UI 変更なし

その他

@Hiroshiba Hiroshiba changed the title Inline engine setting update chore: updateEngineSettingをインライン化 Oct 1, 2025
@Hiroshiba Hiroshiba requested a review from Copilot October 1, 2025 12:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the engine setting update functionality by inlining the updateEngineSetting method directly into the IPC handler and removing the now-unused method from the EngineAndVvppController class.

  • Inlined engine setting update logic in the SET_ENGINE_SETTING IPC handler
  • Removed the updateEngineSetting method from EngineAndVvppController class

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/backend/electron/ipcMainHandle.ts Replaced method call with inline engine setting update logic
src/backend/electron/engineAndVvppController.ts Removed unused updateEngineSetting method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@voicevox-preview-pages
Copy link

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:7a81c46

Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

特に問題なさそう。

@Hiroshiba
Copy link
Member Author

あ、問題なさそうならマージまでしちゃっていただけると…!

@sevenc-nanashi
Copy link
Member

マージしようとしてCI回してたんですけどなかなか通らないんですよね...特に関係ない場所なので多分運が悪いだけだと思ってます

@sevenc-nanashi
Copy link
Member

あ、通ってた

マージします。

@sevenc-nanashi sevenc-nanashi added this pull request to the merge queue Oct 2, 2025
Merged via the queue into VOICEVOX:main with commit 016bbb0 Oct 2, 2025
31 of 35 checks passed
@Hiroshiba Hiroshiba deleted the inline-engine-setting-update branch October 2, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants