Skip to content

Conversation

Hiroshiba
Copy link
Member

内容

タイトルのとおりです。公式から提供されてたので追加してみました。
今のテストだと「テストはexpectが1つ以上含まれてるべき」ルールに引っかかってるのがいくつかあったので、とりあえず対処しています。

関連 Issue

ref: #2627

その他

ぶっちゃけ恩恵はあまりない気がします。
nodeのtestをimportしてたときにエラーにするみたいなのも入ってて、初学者の助けになるかもしれない・・・?
https://github.com/vitest-dev/eslint-plugin-vitest/

@Hiroshiba Hiroshiba requested a review from a team as a code owner March 23, 2025 15:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the official vitest ESLint plugin to the project configuration and updates tests to comply with the new "expect-expect" rule.

  • Added vitest plugin import and configuration in eslint.config.js
  • Disabled the "vitest/expect-expect" rule in a couple of test files where no assertions are needed
  • Renamed the engine directory check function in backend tests for consistency

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

File Description
eslint.config.js Added vitest plugin import and configuration, including the "vitest/expect-expect" rule
tests/unit/components/help/HelpMarkdownViewSection.spec.ts Disabled the "vitest/expect-expect" rule with an inline comment
tests/unit/lib/hotkeyManager.spec.ts Added an eslint inline disable for the "vitest/expect-expect" rule
tests/unit/backend/electron/vvppFile.node.spec.ts Renamed the engine directory check function from assertIsEngineDir to expectIsEngineDir
Files not reviewed (2)
  • package.json: Language not supported
  • pnpm-lock.yaml: Language not supported

@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Mar 23, 2025

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:24525b9

Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう。

@Hiroshiba Hiroshiba enabled auto-merge March 24, 2025 13:50
@Hiroshiba Hiroshiba added this pull request to the merge queue Mar 24, 2025
Merged via the queue into VOICEVOX:main with commit 8f3a353 Mar 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants