-
Notifications
You must be signed in to change notification settings - Fork 337
fix: Tabキーで自動スクロールしない問題を修正(#2599) #2606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This pull request resolves the issue reported in #2599 by ensuring that the lyric input scrolls into view when the Tab key is pressed.
- Added a scrollIntoView call to the lyric input element
- Ensures consistent auto-scroll behavior when the element is focused
Reviewed Changes
File | Description |
---|---|
src/components/Sing/SequencerLyricInput.vue | Added scrollIntoView in the focus sequence to fix auto-scroll |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/components/Sing/SequencerLyricInput.vue:70
- [nitpick] Consider adding tests to verify the auto-scroll behavior when the Tab key is pressed to ensure consistent results across browsers.
lyricInput.value?.scrollIntoView({ block: "nearest", inline: "nearest" });
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
特に問題なさそう。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
内容
Tabキーで自動スクロールしない問題を修正。
関連 Issue
ref #2599
スクリーンショット・動画など