fix: 「くわ」が別モーラとして分割されない問題を修正 #2604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Overview
This PR fixes the issue where "くわ" was not being split into separate moras, addressing #2600. Key changes include:
- Adding a new test case in tests/unit/lib/splitLyricsByMoras.spec.ts to verify the correct handling of "くわ" versus "くゎ".
- Updating the regular expression in src/domain/japanese/index.ts to change "[くぐ][わ]" to "[くぐ][ゎ]", ensuring that "くわ" is split as separate moras.
Reviewed Changes
| File | Description |
|---|---|
| tests/unit/lib/splitLyricsByMoras.spec.ts | Added test case for special string handling of "くわ" and "くゎ". |
| src/domain/japanese/index.ts | Modified regex pattern for proper separation of "くわ" into distinct moras. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
sevenc-nanashi
approved these changes
Mar 8, 2025
Member
sevenc-nanashi
left a comment
sevenc-nanashi
left a comment
There was a problem hiding this comment.
LGTM（うーんこの）
コア/エディタはカタカナのregexで、かつちゃんと動いてそうなのでこっちの修正はいらなさそう。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
を解決します。
信じられないほど簡単なミスでした。。
関連 Issue
close #2600
その他