Skip to content

fix!: bpmInputBufferをなくしつつ、再生中でもbpmを変更できるようにする #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 10, 2025
Merged

fix!: bpmInputBufferをなくしつつ、再生中でもbpmを変更できるようにする #2603

merged 7 commits into from
Mar 10, 2025

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Mar 8, 2025 •
edited
Loading

内容

の解決案です。

  • 再生中じゃないときは普通に編集できる
  • 再生中にinputの上下ボタンを押しても普通に編集できる
  • 再生中にinputの文字変更もできる
  • 再生中にbpm区間が変わってbpmの値が変わった場合でも入力中の値は消えない
  • 再生中に入力し、bpm区間が変わった後に確定すると、変わった後のbpm区間のbpmが変わる

関連 Issue

close #2593

その他

@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Mar 8, 2025 •
edited
Loading

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ：8db5d92

@Hiroshiba Hiroshiba mentioned this pull request Mar 8, 2025
Closed
@Hiroshiba Hiroshiba requested a review from Copilot March 8, 2025 21:11
Copilot
Copilot AI reviewed Mar 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR addresses issue #2593 by removing the redundant bpmInputBuffer and enabling bpm updates during playback.

  • Removes bpmInputBuffer and associated update logic
  • Updates QInput bindings and event handlers to directly use the computed bpm value

Reviewed Changes

File Description
src/components/Sing/ToolBar/ToolBar.vue Refactors bpm handling by replacing bpmInputBuffer with a computed property and renaming the associated update function

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@Hiroshiba Hiroshiba marked this pull request as ready for review March 9, 2025 08:21
@Hiroshiba Hiroshiba requested a review from a team as a code owner March 9, 2025 08:21
@Hiroshiba Hiroshiba requested a review from sigprogramming March 9, 2025 08:24
Hiroshiba
Hiroshiba commented Mar 9, 2025
View reviewed changes
Copy link
Member Author

@Hiroshiba Hiroshiba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

draft開けました！
ついでにRangeAdjustment系も同じように揃えてメンテナンス性を上げました。

sigprogramming
sigprogramming approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@sigprogramming sigprogramming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！
修正ありがとうございます！

@Hiroshiba Hiroshiba enabled auto-merge March 10, 2025 11:23
@Hiroshiba Hiroshiba added this pull request to the merge queue Mar 10, 2025
Merged via the queue into VOICEVOX:main with commit cb5c86a Mar 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@sigprogramming sigprogramming sigprogramming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ソング：再生中に左上のテンポ入力欄でテンポ変更できない
2 participants
@Hiroshiba @sigprogramming