chore: ESLintのキャッシュを有効化 #2597
Merged
chore: ESLintのキャッシュを有効化 #2597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Config Inspectorというリントのルールを可視化してくれるツールを起動するためのコマンドらしい https://eslint.org/docs/latest/use/command-line-interface#--inspect-config
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
nanae772
commented
Mar 6, 2025
package.json
Outdated
| "scripts": { | ||
| "// --- lint ---": "", | ||
| "lint": "eslint .", | ||
| "lint": "eslint --cache", |
Contributor
Author
There was a problem hiding this comment.
flat configuration fileがある場合は.はあっても無くても同じだと公式ドキュメントに書いてあったため、lint:inspectorとの統一感を出すために何となくで消してしまいました。
https://eslint.org/docs/latest/use/command-line-interface#run-the-cli
Contributor
There was a problem hiding this comment.
PR Overview
This PR updates documentation to inform contributors about ESLint’s cache behavior in the repository, detailing when and how the cache file is created and managed.
- Added instructions for ESLint cache creation and removal in CONTRIBUTING.md.
- Added corresponding instructions in README.md.
Reviewed Changes
| File | Description |
|---|---|
| CONTRIBUTING.md | Added information about the ESLint cache file and its management. |
| README.md | Included similar instructions regarding the ESLint cache behavior. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Contributor
Author
|
レビューありがとうございます。 |
Hiroshiba
reviewed
Mar 8, 2025
Hiroshiba
reviewed
Mar 8, 2025
Hiroshiba
approved these changes
Mar 8, 2025
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM！！
eslintの実行が重いの結構気になってたので助かりました！！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
表題の通りです。
README.mdとCONTRIBUTING.mdのキャッシュについての案内はコピペになってしまっていますが、どちらも見る人がいそうなので書いておきました。
関連 Issue
close #2592
スクリーンショット・動画など
その他