refactor: electronのカレントディレクトリの変更のロジックを関数の外に出す #2569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Contributor
There was a problem hiding this comment.
PR Overview
This PR refactors the logic that changes Electron's current working directory by separating the side-effect from the utility function.
- Renames the function from initializeAppPaths to getAppPaths to indicate it no longer includes side effects.
- Moves the process.chdir call to a separate production-only code block.
Reviewed Changes
| File | Description |
|---|---|
| src/backend/electron/main.ts | Refactors path initialization and delays the directory change call |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/backend/electron/main.ts:116
- [nitpick] The new name 'getAppPaths' implies a pure function, but consider a name that more clearly indicates its purpose of computing paths without side effects, such as 'resolveAppPaths'.
function getAppPaths() {
Hiroshiba
commented
Feb 28, 2025
Comment on lines
+133
to
+137
| // 製品版はカレントディレクトリを.exeのパスにする | ||
| // TODO: ディレクトリを移動しないようにしたい | ||
| if (!isDevelopment) { | ||
| process.chdir(appDirPath); | ||
| } |
Member
Author
There was a problem hiding this comment.
やっぱカレントディレクトリには依存しないほうが良いな～と思ったのでTODO書くのが良いかなと！
まあすぐ依存外すPR作る予定ですが。
Member
Author
|
レビューありがとうございます！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
electronのカレントディレクトリの変更を関数の外に出し、関数の副作用を分離しました。
その他
そもそもカレントディレクトリを変えるべきではないよなぁと感じたのでTODOコメント書いてみました。
TODOにすべきかは賛否両論な気がするので、↓にいろいろ考えを書いてみました。