chore: 7zやtyposのダウンロードをリトライする #2566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
requested review from
Copilot and
sevenc-nanashi
and removed request for
sevenc-nanashi
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tools/helper.ts:11
- [nitpick] The loop using 'retries - 1' might be confusing and could potentially lead to off-by-one errors if 'retries' is set to 0 or 1. Consider iterating exactly 'retries' times and moving the delay logic inside the loop to handle all attempts uniformly.
for (let i = 0; i < retries - 1; i++) {
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
downloadTypos内にあるfetchをリトライするようにしてみました。
https://github.com/VOICEVOX/voicevox/actions/runs/13535774481/job/37827107361
で落ちてmerge-queueが失敗したので実装してみました。
その他