refactor: backendにあったファイル読み込み系統の関数を統一 #2542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ファイル読み込み系統の関数を統一し、重複を減らします。
引数はこうしてみました。
mimeTypeはelectronバックエンドで使えず、defaultPathはブラウザバックエンドで使えません。
まあ共通化しちゃっていいかなぁと。
関連 Issue
close #2522
その他
同様にファイル書き出し系のダイアログも統一できると思います。
といっても現状はSHOW_PROJECT_SAVE_DIALOGとSHOW_EXPORT_FILE_DIALOGだけかも。
やっぱりDRY原則は正しい気がします。