fix: VVPPデフォルトエンジンダウンロード後、確実にファイルが閉じられるまで待つ #2466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Member
Author
|
windowsでのe2eテストを５回回して全部成功だったので、たぶん解決した気がします！ |
Member
Author
|
テストがflakyでたまに落ちちゃうのは良くないのと、まあたぶん大丈夫だと思うので、マージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
VVPPデフォルトエンジンダウンロード後、確実にファイルが閉じられるまで待ちます。
close()を呼んで制御が返ってきても、OSがファイルを閉じているとは限らない･･･っぽい？
ので待機するようにしてみます。
関連 Issue
fix #2459
スクリーンショット・動画など
その他