refactor: ホットキー設定のデフォルト値やConfigManagerをisMac指定可能に #2426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
changed the title
Hiroshiba
commented
Dec 21, 2024
| }); | ||
| export type HotkeySettingType = z.infer<typeof hotkeySettingSchema>; | ||
|
|
||
| // ホットキーを追加したときは設定のマイグレーションが必要 |
Member
Author
There was a problem hiding this comment.
このPRと関係ないけど、自動的に行われるはずなのでこのコメントは要らないはず
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Member
Author
|
まあ問題ない･･･はず･･･？ なのでマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ホットキー設定のデフォルト値やConfigManagerをisMac指定可能にしてテスタブルにします。
変更行数はやたら多いけど、ほとんどが空白追加です。
その他
こういう設計を最初に実装するときから思いつけるようになりたい。