ソング: 一部のUSTが読めないのを修正 #1956 #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Mar 28, 2024
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM！！
公式の仕様書がないとなかなか難しいですね･･･！
hotfixとして急遽更新することもできそうですが、そんなに報告件数がないのと、まあmusicxml等の迂回策もあると思うので、次のアップデート時に修正する形にできればと思います！
Hiroshiba
pushed a commit
to Hiroshiba/voicevox
that referenced
this pull request
Apr 5, 2024
Co-authored-by: Romot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
一部のUST(SynthesizerVなど)でノートセクションの形式が異なるため
インポートできないのを修正
正規表現で #以降数字4桁
/^#\d{4}/としていたが、 #以降数字/^#\d+$/)に変更関連 Issue
ref #1956
close #1956
スクリーンショット・動画など
なし
その他