ログの改善 #1910
Merged
ログの改善 #1910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Mar 6, 2024
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
LOG_WARNとか消しちゃうのいいですね！
２経路あるの気になってたので、こっち消しちゃう形で賛成です。
Member
Author
|
レビューを反映しました。 |
Hiroshiba
reviewed
Apr 8, 2024
src/domain/frontend/log.ts
Outdated
| @@ -1,4 +1,5 @@ | |||
| /** ログ出力用の関数を生成する。ブラウザ専用。 */ | |||
| // TODO: DIできるようにする | |||
Member
There was a problem hiding this comment.
目的語があるとコメントが不要になったかどうかの判断しやすいかも
Suggested change
| // TODO: DIできるようにする | |
| // TODO: window.backendをDIできるようにする |
src/store/engine.ts
Outdated
| error: e, | ||
| message: `Failed to restart engine: ${engineId}`, | ||
| }); | ||
| const { error } = createLogger("RESTART_ENGINES"); |
Member
There was a problem hiding this comment.
store内のローカルのcreateLogger残ってそうです
他にも後何個かありそう
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
[scope] messageのログを作る機構を統一します。また、このフォーマットに沿っていないところをこのフォーマットを使うようにします。
関連 Issue
（なし）
スクリーンショット・動画など
（なし）
その他
（なし）