template内のコンポーネントの名称をPascalCaseに変更 #1874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm-ayf
force-pushed
the
component-name-in-template-casing
branch
from
79d775c to
3d76594
Compare
Contributor
Author
|
テストが落ちてますが、コンポーネントがどこで定義されているか解決できてなさそうな感じです。vueとquasarに詳しい方から助言いただけると嬉しいです…… |
Member
|
@cm-ayf 設定変更したら動きました！（１５分かかりました 😇 ） |
Hiroshiba
changed the title
Contributor
Author
|
ありがとうございます！ |
Contributor
Author
|
|
Contributor
Author
|
よさそうですね。 |
Member
|
まあ差分も明確ですし、コンフリクトは別に良いかなと思いました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
<template>内に書くコンポーネント名をkebab-caseからPascalCaseに変えました．変更にあたっては，そのようなことを行ってくれるESLintルール https://eslint.vuejs.org/rules/component-name-in-template-casing を利用しました．
関連 Issue
closes: #1873