[project-s] 重なっているノートを検出して色を変えて表示する機能を追加 #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Dec 23, 2023
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM！！
dev環境じゃない状態で起動する方法を調べてみました。
いろいろややこしいので実際にビルドしちゃうのが手っ取り早そうでした！
ビルドコマンド↓
npm run electron:build -- --dirビルド完了後はdist_electron/win-unpacked/VOICEVOX.exeができてるはずです。
エンジンが同梱されないので、実行するとエンジン起動エラーが表示されると思います。
別でエンジンrun.exeを起動してあげればUIが表示されるかなと！
（ただ製品のVOICEVOXと同じconfigファイルを見るので、configの状況によっては正しく表示されないかもです）
| }); | ||
| const selectedNoteIds = computed(() => state.selectedNoteIds); | ||
| const selectedNotes = computed(() => { | ||
| const selectedNoteIds = new Set(state.selectedNoteIds); |
Member
There was a problem hiding this comment.
selectedNoteIdsはもともと`Setにしておいても良いかもですね！
Comment on lines
+107
to
115
| const classNamesStr = computed(() => { | ||
| if (state.selectedNoteIds.includes(props.note.id)) { | ||
| return "sequencer-note selected"; | ||
| } | ||
| if (state.overlappingNoteIds.includes(props.note.id)) { | ||
| return "sequencer-note overlapping"; | ||
| } | ||
| return "sequencer-note"; | ||
| }); |
Member
There was a problem hiding this comment.
文字列の配列を返してもいけるかも･･･？
https://ja.vuejs.org/guide/essentials/class-and-style#binding-to-arrays
つまりこんな感じも。（sequencer-noteのコピペを抑えられる）
const classes = ["sequencer-note"]
if(selected) { classes.push("selected") }
else if(overlapped) { classes.push("overlapping") }
return classes
Comment on lines
+727
to
+729
| const scoreNotes = state.score.notes; | ||
| const existingIds = new Set(scoreNotes.map((value) => value.id)); | ||
| const isValidNoteIds = noteIds.every((value) => existingIds.has(value)); |
Member
There was a problem hiding this comment.
この処理結構見かけるのでGETTER辺りに置いても良いかもと思いました！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
重なっているノートを検出して色を変えて表示する機能を追加します。
また、以下も行います。
ADD_NOTEからADD_NOTESに変更（複数ノートに対応）UPDATE_NOTEからUPDATE_NOTESに変更（複数ノートに対応）REPLACE_ALL_NOTESを削除REMOVE_NOTEからREMOVE_NOTESに変更（複数ノートに対応）SET_SELECTED_NOTE_IDSのactionを削除SELECT_NOTESを追加CLEAR_SELECTED_NOTE_IDSからDESELECT_ALL_NOTESに変更REMOVE_SELECTED_NOTESのmutationを削除（REMOVE_NOTESを呼び出すように変更）REPLACE_ALL_NOTESを削除したので、それに合わせてドラッグ周りの処理を修正state.overlappingNoteIdsを元に削除するように変更重なっているノートを検出する処理は計算量が$O(n^2)$ になっています。
関連 Issue
VOICEVOX/voicevox_project#15
その他