[project-s] 再生ヘッドの描画処理とオートスクロールを実装 #1649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Nov 12, 2023
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
再生位置がしっかり追従していてすごいなと思いました！！！！
いくつかコメントしていますが、ドキュメント（というよりメモ）の追加と質問のとこが主です！
Comment on lines
+50
to
+55
| <div | ||
| class="sequencer-ruler-playhead" | ||
| :style="{ | ||
| transform: `translateX(${playheadX - offset}px)`, | ||
| }" | ||
| ></div> |
Member
There was a problem hiding this comment.
将来的にルーラー部分とシーケンサー部分の共通の親にplayheadを１つだけもたせる形にしても良いかもですね！
Hiroshiba
reviewed
Nov 12, 2023
Hiroshiba
approved these changes
Nov 20, 2023
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM！！！
レビューが遅れてしまってすみませんでした 🙇
スピード優先なはずなので、次からは大問題がなければコメントしつつとりあえずマージさせて頂く形にしようかなと･･･！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
以下を行います。
translateで実装requestAnimationFrameを使用して更新（最大60fps）関連 Issue
VOICEVOX/voicevox_project#15
スクリーンショット・動画など
2023-11-11.234147.mp4
その他