[project-s] ズーム周りの調整 #1640
Merged
[project-s] ズーム周りの調整 #1640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Nov 6, 2023
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
ほぼLGTMです！！
ResizeObserver
なるほどです！
heightやwidthはsvgに必要で、であれば外から与えるよりコンポーネント内で完結させるこの形が良いように感じました！！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
スライダーを操作したときは画面の中央を基準にズーム、
Ctrlキーを押しながらホイールを回したときはマウスカーソル位置を基準にズーム（水平方向）するようにします。
また、
SequencerKeysの幅とSequencerRulerの高さをResizeObserverで取得するようにします。関連 Issue
VOICEVOX/voicevox_project#15
スクリーンショット・動画など
2023-11-05.234522.mp4
その他