Update: 警告が出ていた依存を更新 #1635
Merged
Update: 警告が出ていた依存を更新 #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
commented
Nov 3, 2023
Comment on lines
+98
to
+105
| const getMenuBarHotkey = (rawLabel: string) => { | ||
| const label = hotkeyActionSchema.safeParse(rawLabel); | ||
| if (!label.success) { | ||
| return ""; | ||
| } | ||
| const hotkey = hotkeySettingsMap.value.get(label.data); | ||
| if (hotkey == undefined) { |
Member
Author
There was a problem hiding this comment.
zodのバージョンが上がった関係（多分）で型が厳しくなっていたので良い感じに修正しました。
Hiroshiba
reviewed
Nov 3, 2023
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
immerをダウングレードした旨のコミットがあったのでちょっと調べてみたのですが、解決できるかもでした。
今回のPRでは不要そうですが、次機会があったときに思い出せるようメモっておこうかなと！
import { enablePatches as enablePatchesImpl } from "immer/src/plugins/patches";のとこでimmer/src/plugins/patchesがなくてこける感じなんですね。
わかんないけど、↓で行けそうでした。
import {enablePatches} from "immer"
enablePatches()
Hiroshiba
approved these changes
Nov 3, 2023
Member
There was a problem hiding this comment.
LGTM！！！
ビルドが回るか見守ってみたいと思います！
たぶんこちら https://github.com/VOICEVOX/voicevox/actions/runs/6747476440
Member
|
ビルド完了済みのを動かしてみた感じ、レンダラーが動かない感じでした 😇 ログも特に吐かれてないので、どこが原因なのかパッと分かりませんでした。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
警告が出ていた依存を更新します。0 vulnerabilitiesまで減らしました。
ちなみにこのアプデでelectron-builderの拡張子割り当てで日本語が使えるようになってたりelectron-builder.config.tsにできたりするはずです
関連 Issue
（なし）
スクリーンショット・動画など
その他
（なし）