[project-s] state.scoreからundefinedを消す #1622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
requested review from
y-chan
and removed request for
a team and
y-chan
Hiroshiba
commented
Oct 25, 2023
| setup() { | ||
| return null; | ||
| return {}; |
sigprogramming
approved these changes
Oct 26, 2023
Collaborator
sigprogramming
left a comment
sigprogramming
left a comment
There was a problem hiding this comment.
ありがとうございます！LGTMです！
undefinedのチェックを行っているところも後で修正したいと思います…！
Member
Author
|
マージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
型を簡単にできそうだったのでやってみました。
state.score?.hoge ?? fugaとなっているところをundefined考慮しない形にできそうだったのですが、とりあえずundefinedを省いただけにしました。関連 Issue
ref VOICEVOX/voicevox_project#15
その他
ついでにsetupでnullを返すとワーニングが出るっぽいのでそちらも変更しておきました。