[project-s] 拍子周りの修正とリファクタリング #1621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigprogramming
commented
Oct 25, 2023
| // 歌声合成エディターの初期化 | ||
| onMounted(async () => { | ||
| await store.dispatch("SET_SCORE", { score: createEmptyScore() }); |
Collaborator
Author
There was a problem hiding this comment.
watchが動いていなかったので、ひとまずSET_SCOREを呼んで初期化するようにしました…！
Hiroshiba
approved these changes
Oct 25, 2023
Member
Hiroshiba
left a comment
Hiroshiba
left a comment
There was a problem hiding this comment.
LGTM！！！
score、すでにundefinedableじゃなくせそうな気がしたのでちょっと試してみます。
Comment on lines
+17
to
+18
| // NOTE: 戻り値の単位はtick | ||
| export function getTimeSignaturePositions( |
Member
There was a problem hiding this comment.
（もしご興味あればくらいのコメントなのですが）
ブランド型を使えば、tick等のnumberを型で区別可能にできたりします！
といっても全部numberではあるので、関数に間違えて渡したりできなくなる程度のメリットしか無いかもですが･･･。
例えば↓がzod使って秒・ミリ秒・ナノ秒をそれぞれブランド型作る方法です。
https://chat.openai.com/share/85e06c91-586d-4872-835e-1ef91a69e56f
ちなみにEngineIdやSpeakerIdなどは型サポートを受けられるようにブランド型になってたりします。
Line 30 in aaf0576
Comment on lines
+71
to
+72
| maxTicks = Math.max(maxTicks, lastTsPosition); | ||
| maxTicks = Math.max(maxTicks, lastTempoPosition); |
Member
There was a problem hiding this comment.
意外とこれでも良かったり！
Suggested change
| maxTicks = Math.max(maxTicks, lastTsPosition); | |
| maxTicks = Math.max(maxTicks, lastTempoPosition); | |
| maxTicks = Math.max(maxTicks, lastTsPosition, lastTempoPosition); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
以下を行います。
関連 Issue
VOICEVOX/voicevox_project#15
その他