テキストをつなげて保存を二回押したときの処理を変更 #1527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-chan
approved these changes
Sep 5, 2023
Member
y-chan
left a comment
y-chan
left a comment
There was a problem hiding this comment.
LGTMです！
extensionはオプショナル引数にしたほうがいいのかなと思いつつ、明示的に指定するほうが事故が起きにくくなるのでこれがいいのかなと思いました！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
上書き防止をしてさらにテキスト防止を２回押した際に２回めに保存したファイルの拡張子がwavになっていたので、txtになるようにしました。
関数の引数で拡張子をいじれるようにしました
関連 Issue
close #1521
スクリーンショット・動画など
その他