Skip to content

Conversation

@stmtk1
Copy link
Contributor

@stmtk1 stmtk1 commented Aug 22, 2023

内容

ドラッグでAudioCellが入れ替えるe2eテストを追加しました。

関連 Issue

#1462

スクリーンショット・動画など

その他

@stmtk1 stmtk1 marked this pull request as ready for review August 23, 2023 07:24
@stmtk1 stmtk1 requested a review from a team as a code owner August 23, 2023 07:24
@stmtk1 stmtk1 requested review from y-chan and removed request for a team August 23, 2023 07:24
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大変遅くなりました...LGTM!
問題ないと思います!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 素敵です!!!!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ファイル名が変わって差分が大きくなっていました。
ファイル名は汎用的に「テキスト欄」とかでも良いかも。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addボタンとかはいったん変数に格納すると見通しさらに良くなるかも?

@Hiroshiba Hiroshiba merged commit 389152e into VOICEVOX:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants